Microsoft.Authorization/Policy* api version 2019-09-01#10658
Merged
VeryEarly merged 1 commit intoAzure:masterfrom Dec 5, 2019
Merged
Microsoft.Authorization/Policy* api version 2019-09-01#10658VeryEarly merged 1 commit intoAzure:masterfrom
VeryEarly merged 1 commit intoAzure:masterfrom
Conversation
mentat9
reviewed
Dec 4, 2019
| /// <returns></returns> | ||
| protected JArray GetArrayFromParameter(string parameter, string parameterName) | ||
| { | ||
| var result = this.GetTokenFromParameter(parameter) as JArray; |
Member
There was a problem hiding this comment.
You can use an is-pattern here (and above in GetObjectFromParameter()):
if (this.GetTokenFromParameter(parameter) is JArray result)
{
return result;
}
throw new PSArgumentException(string.Format(ProjectResources.JsonArrayExpected, parameterName), parameterName);
mentat9
reviewed
Dec 4, 2019
| public const string NewPolicySetDefinitionMetadataHelp = "The metadata for the new policy set definition. This can either be a path to a file name containing the metadata, or the metadata as a string."; | ||
| public const string NewPolicySetDefinitionPolicyDefinitionHelp = "The policy definition for the new policy set definition. This can either be a path to a file name containing the policy definitions, or the policy set definition as a string."; | ||
| public const string NewPolicySetDefinitionParametersHelp = "The parameters declaration for the new policy set definition. This can either be a path to a file name or uri containing the parameters declaration, or the parameters declaration as a string."; | ||
| public const string NewPolicySetDefinitionPolicyDefinitionHelp = "The policy definitions for the new policy set definition. This can either be a path to a file containing the policy definitions, or the policy set definition as a JSON string."; |
mentat9
approved these changes
Dec 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding a new parameter to the New-AzPolicySetDefinition and Set-AzPolicySetDefinition cmdlets to support grouping of policy definitions within the policy set.
Design review is at: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/446
Checklist
CONTRIBUTING.mdChangeLog.mdfile(s) has been updated:ChangeLog.mdfile can be found atsrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md## Upcoming Releaseheader -- no new version header should be added